Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[collector] Only add service check fields if non-null #3487

Merged
merged 1 commit into from
Aug 22, 2017
Merged

[collector] Only add service check fields if non-null #3487

merged 1 commit into from
Aug 22, 2017

Conversation

olivielpeau
Copy link
Member

@olivielpeau olivielpeau commented Aug 22, 2017 •
edited
Loading

What does this PR do?

Avoids null values on service check fields.

Motivation

The api/v1/check_run endpoint doesn't accept payloads with a message value of null, so avoid that. #3446 was not working because of this.

Do the same thing on the tags and hostname fields as it makes sense to be consistent.

cc @remh

@olivielpeau
[collector] Only add service check fields if non-null
f16dee7 
The `api/v1/check_run` endpoint doesn't accept payloads with
a `message` value of `null`, so avoid that. Do the same thing on the
`tags` and `hostname` fields as it makes sense to be consistent.
@olivielpeau olivielpeau added this to the 5.17 milestone Aug 22, 2017
remh
remh approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@remh remh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

olivielpeau added a commit that referenced this pull request Aug 22, 2017
@olivielpeau
[collector] Only add service check fields if non-null (#3487)
e6b389d 
The `api/v1/check_run` endpoint doesn't accept payloads with
a `message` value of `null`, so avoid that. Do the same thing on the
`tags` and `hostname` fields as it makes sense to be consistent.
@olivielpeau olivielpeau merged commit e6b389d into master Aug 22, 2017
@olivielpeau olivielpeau deleted the olivielpeau/fix-null-sc-message-field branch August 22, 2017 19:43
@olivielpeau olivielpeau mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remh remh remh approved these changes

Assignees
No one assigned
Labels
bugfix core
Projects
None yet
Milestone
5.17
Development

Successfully merging this pull request may close these issues.
2 participants
@olivielpeau @remh